[PATCH] D130980: [AA] Model operand bundles more precisely

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added inline comments.


================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:267
+  /// Create FunctionModRefBehavior that can write any memory.
+  static FunctionModRefBehavior writeOnly() {
+    return anyLoc(ModRefInfo::Mod);
----------------
Was wondering why you missing this when looking into D130896. Not super critical but would be nice if you move it there.


================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:368
+  /// Union (in-place) with another FunctionModRefBehavior.
+  FunctionModRefBehavior operator|(FunctionModRefBehavior Other) const {
+    return FunctionModRefBehavior(Data | Other.Data);
----------------
Same suggestion as for writeOnly. Let's move it to the patch where API is introduced.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130980/new/

https://reviews.llvm.org/D130980