[PATCH] D130896: [AA] Tracking per-location ModRef info in FunctionModRefBehavior (NFCI)

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added a comment.

Hi @nikic

Thanks for moving this forward! In general, the direction looks good to me. Before commenting on specific things I would like to discuss one high level thing. I found new FMRB interface a bit overloaded. It's was hard to quickly understand which API  creates new FMRB instance and which makes in place update. My proposal would be:

1. Make FMRB non-mutable (that would also allow to use static instances for common cases like none, unknown, etc...)
2. Move location specific API from FMRB to Location. That would separate things out and allow to reduce total number of public API. For example, argMemOnly(ModRefInfo MR) would be not needed as one can simply instantiate FMRB through public constructor.
3. Don't introduce withModRef & withoutLoc. Instead model operations through 'operator &' and 'operator |'

What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130896/new/

https://reviews.llvm.org/D130896