[PATCH] D133089: [LLVM] Replace `dyn_cast_or_null` with `dyn_cast_if_present`, NFC.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 00:29:46 PDT 2022


nikic added a comment.

While the new name represents the //capabilities// better, the way these functions are used in LLVM, we are actually working with null values. I find the original names (both here and in D133090 <https://reviews.llvm.org/D133090>) substantially clearer. I don't think we should do this rename.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133089/new/

https://reviews.llvm.org/D133089



More information about the llvm-commits mailing list