[PATCH] D132996: [InstCombine] complete fold extractvalue (any_mul_with_overflow X, -1)

[Chenbing.Zheng via Phabricator via llvm-commits]

Chenbing.Zheng marked an inline comment as done.
Chenbing.Zheng added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3290
   // checking for overflow.
-  const APInt *C;
-  if (match(WO->getRHS(), m_APInt(C))) {
+  if (WORHSC) {
     // Compute the no-wrap range for LHS given RHS=C, then construct an
----------------
spatel wrote:
> We need a test for this transform too? (and confirm that it is safe)
It seems that the tests we fix in this patch can also test for this transform, and I add Alive2 conform in summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132996/new/

https://reviews.llvm.org/D132996