[PATCH] D133065: [nfc][msan] Group checks per instruction

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1319
+      // Process all checks of instruction at once.
+      materializeInstructionChecks(InstrumentWithCalls,
+                                   ArrayRef<ShadowOriginAndInsertPoint>(I, J));
----------------
vitalybuka wrote:
> kda wrote:
> > I wonder if making an implementation that materializes one check would avoid this awkward slicing.
> > 
> > I think you could cook all the logic from materializeInstructionChecks into materializeOneCheck and be done.
> Not sure what are you asking, the point is to materialize them in batches, so we can combine checks
> Not sure what are you asking, the point is to materialize them in batches, so we can combine checks

 D133071 is the reason for slicing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133065/new/

https://reviews.llvm.org/D133065