[PATCH] D132700: [DSE] Add value type checks for masked store candidates in Dead Store Elimination

[Michael Berg via Phabricator via llvm-commits]

mcberg2021 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:251
+    if (KillingII->getArgOperand(0)->getType() !=
+        DeadII->getArgOperand(0)->getType())
+      return OW_Unknown;
----------------
fhahn wrote:
> mcberg2021 wrote:
> > fhahn wrote:
> > > StephenFan wrote:
> > > > Is it possible to relax the comparison from type to type size?
> > > Yeah it would be good to check the stored sizes instead of requiring the types to match. I think we should remove one store if both masked stores are flipped.
> > Well, we have an ulterior motive, VLA uses VL with type to constrain size.
> Right, so  it sounds like this should also 1) have tests with scalable vectors and 2) different handling for scalable vs non-scalable vectors?
We would like to keep this patch to just the fixed non-scalable vectors like in this example.  I can add the type size and I think element count would also be useful, as it is within context of this intrinsic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132700/new/

https://reviews.llvm.org/D132700