[PATCH] D133057: [WebAssembly][MC] Improve error handling on empty function declarations

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 15:03:58 PDT 2022


sbc100 added a comment.

In D133057#3762475 <https://reviews.llvm.org/D133057#3762475>, @dschuff wrote:

> IIUC in other asm formats, you can just e.g. switch to the data section (in the middle of generating code for a function), emit a data constant, and then switch back and finish the function. In theory we could do that for wasm too, as long as we do actually switch back and finish the function. but I get that would make this error checking a lot more complicated, and I don't know of any cases where we would actually want to do that. do you?

I can't think of any no.. but at the same time I didn't indent this change to change that behaviour.  I will check if that is possible prior to this change.. if it is possible, we can reconsider.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133057/new/

https://reviews.llvm.org/D133057



More information about the llvm-commits mailing list