[PATCH] D133037: [lld][WebAssemby] Allow import module names to be empty strings.

[Dan Gohman via Phabricator via llvm-commits]

sunfish added a comment.



In D133037#3762343 <https://reviews.llvm.org/D133037#3762343>, @sbc100 wrote:

> The change to the code here seems only to relate to the module and the not the name/field of the import, is that right?   Were fields already allowed to be empty?   In which case maybe the title should just be "Allow empty module names in imports?"

The actual change is just for module names. Empty fields were already supported. I've now updated the title.

> is the canonical ABI using empty fields or empty module names?  (presumably one can't use both .. otherwise everything is the same import :)

The canonical ABI is using empty module names for some things.

In D133037#3762383 <https://reviews.llvm.org/D133037#3762383>, @sbc100 wrote:

> Actually perhaps we can just make this part of the existing `lld/test/wasm/import-module.ll`, and `lld/test/wasm/import-name.ll` tests.. i don't see why they shouldn't test the different edge cases in the single test file   (if you do it that way I guess you can avoid re-writing them tests in assembly too :)

I've now done this :-).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133037/new/

https://reviews.llvm.org/D133037