[PATCH] D133037: [lld][WebAssemby] Allow import module names to be empty strings.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 14:31:54 PDT 2022


sbc100 added a comment.

Actually perhaps we can just make this part of the existing `lld/test/wasm/import-module.ll`, and `lld/test/wasm/import-name.ll` tests.. i don't see why they shouldn't test the different edge cases in the single test file   (if you do it that way I guess you can avoid re-writing them tests in assembly too :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133037/new/

https://reviews.llvm.org/D133037



More information about the llvm-commits mailing list