[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

[Alexander Kornienko via Phabricator via llvm-commits]

alexfh added a comment.

In D132998#3760603 <https://reviews.llvm.org/D132998#3760603>, @alexander-shaposhnikov wrote:

> My assumption was that a codebase needs to compile with c++11 in the first place - otherwise the automatic fixit will break the build (as it happens right now).
> I was looking at modernize/UseOverrideCheck.h - it requires c++11 and this seemed to be quite natural.

There may be cases when the code needs to be "modernized" to compile in C++11 mode. But I can only recall some uses of NULL and the corresponding modernize-use-nullptr check. In other cases one can switch compiler options first and then apply clang-tidy fixes. That has a benefit of being able to apply fixes incrementally and is probably a more convenient approach.

This patch would likely make it more convenient to use clang-tidy in codebases with mixed C++ standards. I'm not sure whether it's an important or even practical use case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132998/new/

https://reviews.llvm.org/D132998