[PATCH] D133003: [WIP][ELF] Parallelize relocation scanning
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 12:25:00 PDT 2022
MaskRay added inline comments.
================
Comment at: lld/ELF/Symbols.h:289
- // True if this symbol needs a canonical PLT entry, or (during
- // postScanRelocations) a copy relocation.
- uint8_t needsCopy : 1;
+ uint8_t needsTlsGdToIe : 1;
----------------
ikudrin wrote:
> Why is not `needsTlsGdToIe` moved under `atomic` like `needsTlsGd` and alike?
All the 8 bits of `std::atomic<uint8_t>` have been used. We need one not in atomic if we want to keep the size of `SymbolUnion` unchanged.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133003/new/
https://reviews.llvm.org/D133003
More information about the llvm-commits
mailing list