[PATCH] D126877: [SLP]Fix PR55734: SLP vectorizer's reduce_and formation introduces poison.

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:10561-10564
   // And/or are potentially poison-safe logical patterns like:
   // select x, y, false
   // select x, true, y
   static bool isBoolLogicOp(Instruction *I) {
----------------
I think we should just fix this to include isa<SelectInst>, so it matches the code comment. Then, we don't need the confusing extra variable in this patch. All of the existing uses are checking for SelectInst, so that can be a preliminary cleanup patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126877/new/

https://reviews.llvm.org/D126877