[PATCH] D132893: Add docs for Mach-O lld

Wed Aug 31 10:42:27 PDT 2022

oontvoo added inline comments.

================
Comment at: lld/docs/MachO/index.rst:55
+The user may also need to add ``-Wl,--deduplicate-literals`` in order
+to match Apple's linker behavior more closely.
+
----------------
smeenai wrote:
> michaeleisel wrote:
> > thakis wrote:
> > > Should this point at…uh,  lld/MachO/ld64-vs-lld.rst.
> > > 
> > > Also, we should move  lld/MachO/ld64-vs-lld.rst  out of the source tree into the doc tree, right, @oontvoo?
> > Sure, how about another sentence saying, "For more details on the differences between ld64 and LLD, see [here](...)"? Although, I don't know what the link is. Also, can I render this somehow locally to see how it looks and if the links work?
> Make sure you have `sphinx-build` in your path (I've found `pip` to be the easiest way to do this), and then set `LLVM_ENABLE_SPHINX` to `ON` in your CMakeCache.txt and reconfigure, then build the `docs-lld-html` target. It'll take a bit the first time, but incremental builds should be pretty quick. 
> Should this point at…uh,  lld/MachO/ld64-vs-lld.rst.
> 
> Also, we should move  lld/MachO/ld64-vs-lld.rst  out of the source tree into the doc tree, right, @oontvoo?

Yeah, I think the intention was that we'd keep this ld64-vs-lld.rst here in the source tree until the linker is "officially" released. 
So now is as good a time as any.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132893/new/

https://reviews.llvm.org/D132893