[PATCH] D131959: [AMDGPU] Fix SDST operand of V_DIV_SCALE to always be VCC

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/MC/AMDGPU/wave_any.s:207
-
-v_div_scale_f64 v[2:3], s2, v[0:1], v[0:1], v[2:3]
-// GFX10: v_div_scale_f64 v[2:3], s2, v[0:1], v[0:1], v[2:3] ; encoding: [0x02,0x02,0x6e,0xd5,0x00,0x01,0x0a,0x04]
----------------
It seems the intent of the test was to check that both wave32 and wave64 versions are accepted with both attributes set. This is lost now.


================
Comment at: llvm/test/tools/llvm-mca/AMDGPU/gfx11-double.s:147
 # CHECK-NEXT: [0,8]     .    .    .    .    .    .    .    .    DeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeE.   v_fract_f64_e32 v[4:5], v[4:5]
+# CHECK-NEXT: Truncated display due to cycle limit
 
----------------
Pierre-vh wrote:
> rampitec wrote:
> > foad wrote:
> > > Pierre-vh wrote:
> > > > Not sure why this popped up, I don't really understand the message
> > > Add `--timeline-max-cycles=0` to the RUN line? All the other files in this directory have it.
> > Why did it change at all?
> I don't think it changed, just content was added to it. I think the previous person that updated it didn't add the `--timeline-max-cycles=0` and instead removed the check line with the cycles limit.
> 
> I think I can revert all these and the test should still pass, it'll just cover less instructions?
Then it does not belong to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131959/new/

https://reviews.llvm.org/D131959