[PATCH] D133020: [LAA] Fix ICE with scAddExpr in forked pointers

[Graham Hunter via Phabricator via llvm-commits]

huntergr created this revision.
huntergr added reviewers: efriedma, fhahn, david-arm.
Herald added a subscriber: hiraditya.
Herald added a project: All.
huntergr requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The IR from https://github.com/llvm/llvm-project/issues/57368 results
in an assert firing when trying to create a runtime check for the
forked pointer. One of the forks is fine since it's loop invariant,
but the other is a scAddExpr (containing a scAddRecExpr, so not
invariant) when RtCheck::insert expects a scAddRecExpr.

This is a simple fix to just avoid forks which aren't AddRec or
loop invariant. We can allow it as a forked pointer later with
more work.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133020

Files:
  llvm/lib/Analysis/LoopAccessAnalysis.cpp
  llvm/test/Analysis/LoopAccessAnalysis/forked-pointers.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133020.456951.patch
Type: text/x-patch
Size: 4859 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220831/e675b7b2/attachment.bin>