[PATCH] D132633: [LoongArch] Add more fixups and relocations

Ray Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 05:48:08 PDT 2022


wangleiat added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchMCCodeEmitter.cpp:163
+    case LoongArchMCExpr::VK_LoongArch_PCALA_HI20:
+      FixupKind = ELF::R_LARCH_PCALA_HI20;
+      break;
----------------
Using the relocation numbers directly looks weird. It's better to define in a header file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132633/new/

https://reviews.llvm.org/D132633



More information about the llvm-commits mailing list