[PATCH] D133010: [lld-macho] Set the SG_READ_ONLY flag on __DATA_CONST

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 05:32:56 PDT 2022


int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:8862
+      if (flags & MachO::SG_READ_ONLY) {
+        // Note: Apple's otool has this inconsistency as well.
+        outs() << " SG_READ_ONLY";
----------------
I assume by "this inconsistency" you mean the inclusion of `SG_` prefix in the output? Would be nice to spell it out, took me a sec :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133010/new/

https://reviews.llvm.org/D133010



More information about the llvm-commits mailing list