[PATCH] D133000: [LLParser] Allow zero-input phi nodes

Wed Aug 31 05:12:39 PDT 2022

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - I drafted a similar patch. :)

For reference, the verifier change was 9eb2c0113dfe <https://reviews.llvm.org/rG9eb2c0113dfe2c1054e524122ca0e17ad552bb01>, and that was a follow-up to D92247 <https://reviews.llvm.org/D92247> which tried to fix https://llvm.org/PR48296.

================
Comment at: llvm/lib/AsmParser/LLParser.cpp:7012-7013

   if (!Ty->isFirstClassType())
     return error(TypeLoc, "phi node must have first class type");

----------------
Move this error check directly after parse of Ty? That could be an independent change. It doesn't appear to have any testing currently, but I think we can trigger it with something like:
  %r = phi i8* ()

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133000/new/

https://reviews.llvm.org/D133000