[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added a comment.

In D129352#3760693 <https://reviews.llvm.org/D129352#3760693>, @xiangzhangllvm wrote:

> In D129352#3760370 <https://reviews.llvm.org/D129352#3760370>, @nikic wrote:
>
>> Do we need the IsHugeFunc flag? Can't we use the worklist approach unconditionally? This is what we usually do. Limiting it to IsHugeFunc means that it received essentially zero testing.
>
> I tend first step to add this IsHugeFunc flag, because the new logic may miss some opportunity, compared with old logic, in theory.
> To save build time, the new logic only re-optimize updated BBs. In fact, the un-updated BB may still has opportunity to sink/combine to updated BBs.

And
In fact the performance of new logic is very close to the old logic now.
Even here removed IsHugeFunc flag, all lit tests has no change. 
And I also do spec testing (x86), there is no drop in my local.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352