[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare
Xiang Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 02:44:40 PDT 2022
xiangzhangllvm added a comment.
In D129352#3760370 <https://reviews.llvm.org/D129352#3760370>, @nikic wrote:
> Do we need the IsHugeFunc flag? Can't we use the worklist approach unconditionally? This is what we usually do. Limiting it to IsHugeFunc means that it received essentially zero testing.
I tend first step to add this IsHugeFunc flag, because the new logic may miss some opportunity, compared with old logic, in theory.
To save build time, the new logic only re-optimize updated BBs. In fact, the un-updated BB may still has opportunity to sink/combine to updated BBs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129352/new/
https://reviews.llvm.org/D129352
More information about the llvm-commits
mailing list