[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:8217
+        if (IsHugeFunc)
+          break;
+        else
----------------
xiangzhangllvm wrote:
> LuoYuanke wrote:
> > It should be buggy if the following instrcutions in the BB depends on the dominator tree.
> The break will try re-iterate such BB.
> Do you mean here the BB may be erased ?
> I think the optimizeInst can not erase the BB.
> If it split the BB, it will split it to the BB + new BB, the iteration on such BB still work.
I mean the dominator tree has changed but it is not updated yet. We can't invoke `DT.dominates(...)` before we updating the dominator tree.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352