[PATCH] D132923: [RISCV] Support peephole optimization to fold vmerge.vvm that has tail agnostic policy and unmasked intrinsics.

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:2655
+    } else if (IsVMergeTA(Opc)) {
+      Policy = 1;
+    } else
----------------
fakepaper56 wrote:
> How about using RISCVII::TAIL_AGNOSTIC to replace 1?
Done.


================
Comment at: llvm/test/CodeGen/RISCV/rvv/fixed-vectors-peephole-vmerge-vops.ll:346
+
+; Test binary operator with vp.select and vp.smax.
+define <8 x i32> @vpselect_vpadd(<8 x i32> %passthru, <8 x i32> %x, <8 x i32> %y, <8 x i1> %m, i32 zeroext %vl) {
----------------
craig.topper wrote:
> This comment is incorrect
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132923/new/

https://reviews.llvm.org/D132923