[llvm] 688178a - [Docs][CodeReview] Add a small paragraph on adding tokens, NFC.
via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 30 17:01:23 PDT 2022
Author: bzcheeseman
Date: 2022-08-30T17:01:12-07:00
New Revision: 688178aa2bd3c8b333b1f6d859943ab580988a17
URL: https://github.com/llvm/llvm-project/commit/688178aa2bd3c8b333b1f6d859943ab580988a17
DIFF: https://github.com/llvm/llvm-project/commit/688178aa2bd3c8b333b1f6d859943ab580988a17.diff
LOG: [Docs][CodeReview] Add a small paragraph on adding tokens, NFC.
Reviewed By: whisperity
Differential Revision: https://reviews.llvm.org/D131500
Added:
Modified:
llvm/docs/CodeReview.rst
Removed:
################################################################################
diff --git a/llvm/docs/CodeReview.rst b/llvm/docs/CodeReview.rst
index a22141c142d6..3bd305e93f6f 100644
--- a/llvm/docs/CodeReview.rst
+++ b/llvm/docs/CodeReview.rst
@@ -147,6 +147,12 @@ approved. If unsure, the reviewer should provide a qualified approval, (e.g.,
you are fairly certain that a particular community member will wish to review,
even if that person hasn't done so yet.
+If you approve of the idea/concept of a patch but feel unqualified to approve,
+another option (other than accepting the patch) is to simply *"Award Token"*
+(right-hand side in Phabricator) to indicate support without indicating to
+other reviewers that the patch has been accepted and reviewed in their
+dashboard.
+
Note that, if a reviewer has requested a particular community member to review,
and after a week that community member has yet to respond, feel free to ping
the patch (which literally means submitting a comment on the patch with the
More information about the llvm-commits
mailing list