[PATCH] D132799: Make sure libLLVM users link with libatomic if needed
Aaron Puchert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 30 15:41:34 PDT 2022
aaronpuchert added a comment.
In D132799#3759418 <https://reviews.llvm.org/D132799#3759418>, @beanz wrote:
> We probably should replace `atomic` here with the `LLVM_SYSTEM_LIBS` property from the `LLVMSupport` target.
I wasn't quite sure if all of them are public dependencies, but if that's what they're meant to be, I'd go for that.
What made me suspicious is
if(LLVM_WITH_Z3)
set(system_libs ${system_libs} ${Z3_LIBRARIES})
endif()
since the only use is in `llvm/lib/Support/Z3Solver.cpp`. But to be fair, that's the only one. The other libraries could all conceivably be public dependencies.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132799/new/
https://reviews.llvm.org/D132799
More information about the llvm-commits
mailing list