[PATCH] D132706: [Symbolizer] Handle {{{bt}}} symbolizer markup element.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added a comment.

In D132706#3758922 <https://reviews.llvm.org/D132706#3758922>, @peter.smith wrote:

> Do you need to update the docs/SymbolizerMarkupFormat.rst to say that backtrace is now implemented?

Yes, knew I was forgetting something.



================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-bt.test:13
+CHECK: [[BEGIN:\[{3}]]ELF module #0x0 "a.o"; BuildID=abcdef [0x10-0x10f](r)[[END:\]{3}]]
+CHECK:    #0.0  0x0000000000000018 second /tmp[[SEP:[/\\]]]tmp.c:8:3 (a.o+0x8)
+CHECK:    #0.1  0x0000000000000018 first /tmp[[SEP]]tmp.c:4:3 (a.o+0x8)
----------------
mcgrathr wrote:
> peter.smith wrote:
> > If there is a good place, could be worth an entry in the SymbolizerMarkupFormat or somewhere in the documentation explaining what the X.Y format is. IIUC we'd expect it when there are inlined function(s).
> The markup format does not specify what human-readable output looks like.
> Symbolization of backtraces including "virtual frames" for inlined functions is a QoI question for a particular symbolizing filter and how those are presented is a UI question for a particular presentation style.
> 
> I think it makes sense for the llvm-symbolizer documentation to describe its output formats, but that should not be conflated with the specification of the markup format.
> 
Added this to the llvm-symbolizer documentation.


================
Comment at: llvm/test/DebugInfo/symbolize-filter-markup-bt.test:60
+	.loc	1 8 3 prologue_end              # tmp.c:8:3
+	callq	first
+.Ltmp1:
----------------
peter.smith wrote:
> If I've interpreted this right, there was some function called second, that probably just called first() so it has been inlined here? Only mention of second that I could find was as an inline function.
> 
> May be worth a comment as it could help explain the backtrace.
Added a copy of the source used to generate this as a comment. This should also make it possible to update this example if the debug information goes stale.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132706/new/

https://reviews.llvm.org/D132706