[PATCH] D132073: [CodeGen] Zero out only modified registers

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 14:55:20 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/zero-call-used-regs.ll:13-25
+; I386-NEXT:    .cfi_def_cfa_offset 8
+; I386-NEXT:    pushl %ebx
+; I386-NEXT:    .cfi_def_cfa_offset 12
+; I386-NEXT:    pushl %edi
+; I386-NEXT:    .cfi_def_cfa_offset 16
+; I386-NEXT:    pushl %esi
+; I386-NEXT:    .cfi_def_cfa_offset 20
----------------
consider adding the `nounwind` fn attr to your test functions to eliminate all these obnoxious/verbose CFI directives stemming from `-fasynchronous-unwind-tables`. That should help with readability of the tests significantly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132073/new/

https://reviews.llvm.org/D132073



More information about the llvm-commits mailing list