[PATCH] D64833: [Xtensa 7/10] Add Xtensa instruction printer.

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added inline comments.


================
Comment at: llvm/test/MC/Xtensa/xtensa-invalid.s:13
+# CHECK:      error: expected immediate in range [-128, 127]
+
+# imm8_sh8
----------------
andreisfr wrote:
> saugustine wrote:
> > It would be good to check instruction arguments out of order, and invalid register names.
> You mean for each instruction implement extended tests with argument out of order and invalid register names?
Probably just once for each format, but yes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64833/new/

https://reviews.llvm.org/D64833