[PATCH] D132960: [InstCombine] Transform small unaligned memcmp calls used in zero equality tests

[Eli Friedman via Phabricator via llvm-commits]

efriedma removed a reviewer: mcrosier.
efriedma added a comment.

To be clear, this is proposing to replace a memcmp of 8 bytes with up to 16 byte-sized loads on targets with strict alignment?  That seems excessive to me.

I can see why you'd want to expand this earlier, but I think we need to be a bit more conservative.  Maybe move it to AggressiveInstCombine, and use TTI to check the costs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132960/new/

https://reviews.llvm.org/D132960