[PATCH] D132872: [SLP] Account for loss due to FMAs when estimating fmul costs.

Tue Aug 30 12:46:03 PDT 2022

fhahn marked an inline comment as done.
fhahn added a comment.

>>>> In D132872#3756205 <https://reviews.llvm.org/D132872#3756205>, @ABataev wrote:
>>>>
>>>>> 
>
> I think after this it will live here forever, nobody will try to rework it. It is the same problem as before - the patch does not try to address global problem, instead it introduces an immediate hack.

Fair enough, I put up an alternative series that instead fully sinks the cost logic into TTI: D132968 <https://reviews.llvm.org/D132968>. Personally I am not sure if adding this to TTI is too specific (i.e. encoding SLP specific info into TTI), but if people generally prefer this direction I am happy to go that direction.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132872/new/

https://reviews.llvm.org/D132872