[PATCH] D132823: [llvm-readobj][COFF] Print load config GuardFlags as enum flags

Tue Aug 30 10:48:56 PDT 2022

rnk added a comment.

Looks good, thanks

================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:855
     ListScope LS(W, "GuardFidTable");
     if (Tables.GuardFlags & uint32_t(coff_guard_flags::FidTableHasFlags))
       printRVATable(Tables.GuardFidTableVA, Tables.GuardFidTableCount, 5,
----------------
alvinhochun wrote:
> rnk wrote:
> > Please replace the existing coff_guard_flags enum with the new enum that you just added. It only has 7 hits across the codebase, but some are in LLD. That can also be a follow up CL, if you prefer, but I don't want to carry both duplicate enums long term.
> Sure, I've made D132924.
Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132823/new/

https://reviews.llvm.org/D132823