[PATCH] D132947: [lld-macho] Support synthesizing __TEXT,__init_offsets
Daniel Bertalan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 30 09:51:37 PDT 2022
BertalanD marked 6 inline comments as done.
BertalanD added a comment.
Addressed review comments.
I'm going to wait with landing this until tomorrow in case someone wants to make some suggestions.
================
Comment at: lld/MachO/Driver.cpp:1440
args.hasFlag(OPT_data_in_code_info, OPT_no_data_in_code_info, true);
+ config->emitInitOffsets = args.hasArg(OPT_init_offsets);
config->icfLevel = getICFLevel(args);
----------------
thakis wrote:
> I wanted to ask if this is enabled by default at some output os version, but it looks like it's on by default if chained fixups are on, which are on by default at some output os version. So D132560 will also enable this, I imagine.
That's correct.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132947/new/
https://reviews.llvm.org/D132947
More information about the llvm-commits
mailing list