[PATCH] D131830: Clang Support for taskwait nowait clause
Shilei Tian via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 30 09:33:55 PDT 2022
tianshilei1992 added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:6132
+ const OMPTaskDataTy &Data,
+ bool HaveNoWaitClause) {
if (!CGF.HaveInsertPoint())
----------------
ABataev wrote:
> tianshilei1992 wrote:
> > better to use consistent name as declaration. how about `HasNowaitClause`?
> I would recommend to make it a member of OMPTaskDataTy
Yeah, that sounds better.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131830/new/
https://reviews.llvm.org/D131830
More information about the llvm-commits
mailing list