[PATCH] D132931: [Attributor] Simplify offset calculation for a constant GEP

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 08:52:00 PDT 2022


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, one nit though as pointed out by @nikic .



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1293
+        assert(CannotFail);
+        (void)CannotFail;
 
----------------
Let's allow failure for now, handling as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132931/new/

https://reviews.llvm.org/D132931



More information about the llvm-commits mailing list