[PATCH] D132447: AMDGPU: Add a pass to fix SGPR liveness

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

My understanding is that this pass only fixes specific liveness problems that are created by D132450 <https://reviews.llvm.org/D132450>. It is not a general purpose pass that could handle any possible pattern of SGPR usage.



================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRLiveness.cpp:17
+///
+/// BB1 ends with a divergent branch. The virtual registers shown in above
+/// example are dead in BB2. After register allocation, they may end up
----------------
The implementation does not check that there is a divergent branch, so it would do the same thing for uniform control flow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132447/new/

https://reviews.llvm.org/D132447