[PATCH] D132222: [Assignment Tracking][3/*] Add DIAssignID metadata boilerplate

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

This LGTM, you might want to add explicit tests that the verifier will catch erroneous textual IR, to make sure those code paths get exercised.



================
Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:350
+  METADATA_ARG_LIST = 46,         // [n x [type num, value num]]
+  METADATA_ASSIGN_ID = 47,        // [distinct, ...]
 };
----------------
I wonder what the rules are about assigning these numbers -- they can create future backwards compatibility problems. I suppose this isn't a significant issue until LLVM starts generating bitcode containing these metadata nodes, something that isn't going to happen for quite a while (with this patch series being behind an experimental flag).


================
Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:294
 
+/// Assignment ID
+/// Used to link stores (as an attachment) and dbg.assigns (as an operand).
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132222/new/

https://reviews.llvm.org/D132222