[PATCH] D132908: [RISCV][COST] Add cost model for sqrt/fabs

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Please update the review description to describe actual change.  In this case, I think you're adding half support.



================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:553
     if ((ST->hasVInstructions() && LT.second.isVector()) ||
-        (LT.second.isScalarInteger() && ST->hasStdExtZbb()))
+        (ST->hasStdExtZbb() && LT.second.isScalarInteger()))
+      return LT.first;
----------------
Unrelated change.  Feel free to simply land a change which swaps the order here, but please remove it from this diff.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132908/new/

https://reviews.llvm.org/D132908