[PATCH] D132296: [RISCV] Add cost model for compare and select instructions.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D132296#3757208 <https://reviews.llvm.org/D132296#3757208>, @jacquesguan wrote:

> In D132296#3756224 <https://reviews.llvm.org/D132296#3756224>, @reames wrote:
>
>> Please rebase after landing the parts I asked you to separate and land previously.
>
> Could you give https://reviews.llvm.org/D132827 approved, so that I can land the test first.

I went ahead and formally approved that review, but for future reference, our review approval is only loosely tied to specific reviews.  In a case like this where I've specifically given approval for particular pieces, you can land those without need for a separate review.  This even applies when you've *already* created a separate review; just make sure you include a comment on that review to point to the approval comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132296/new/

https://reviews.llvm.org/D132296