[PATCH] D132221: [Assignment Tracking][2/*] Add flags to enable Assignment Tracking

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

I get the feeling that this is creating two places to store the flag rather than one -- there's the `EnableAssignmentTracking` flag which ends up in TargetOptions I think(?), I believe   `MarshallingInfoFlag<CodeGenOpts<"EnableAssignmentTracking">>;` causes the Xclang flag to be stored there. Then there's the cl::opt flag which is controlled by the same. This raises the future possibility that one could be on, but the other off -- I suspect you'll need to pick one and stick with it.

NB: I've gone off putting things in TargetOptions after finding that they're hard to control (i.e.: impossible) during LTO:

  https://lists.llvm.org/pipermail/llvm-dev/2020-December/147090.html

Because the arguments are parsed after TargetOptions is created.



================
Comment at: clang/include/clang/Basic/CodeGenOptions.def:320
+
+CODEGENOPT(EnableAssignmentTracking, 1,0)
+
----------------
This wants a docu-comment, as in the surrounding flags.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132221/new/

https://reviews.llvm.org/D132221