[PATCH] D132657: [DSE] Eliminate noop store even through has clobbering between LoadI and StoreI

[Nikita Popov via Phabricator via llvm-commits]

nikic added a reviewer: nikic.
nikic added a comment.

Looks reasonable to me



================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1876
+              // is LoadI, actually, the invariant is still kept. So skip in
+              // this case.
+              continue;
----------------
I feel like this comment is overly rambling, something like "This is a potentially clobbering store, but it writes the same value, so we can safely ignore it" should be sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132657/new/

https://reviews.llvm.org/D132657