[PATCH] D132753: [llvm][Testing/ADT] Implement `IsStringMapEntry` testing matcher for verifying the entries in a `StringMap`.

weiyi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 30 06:11:27 PDT 2022


wyt marked an inline comment as done.
wyt added inline comments.


================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:4178
 
+cc_library(
+    name = "testing_adt",
----------------
gribozavr2 wrote:
> Could you put it right before TestingSupport (below), and call it TestingADT (to follow the existing camel case naming convention)?
Creation of the bazel target is moved to parent patch, and renaming has been updated there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132753/new/

https://reviews.llvm.org/D132753



More information about the llvm-commits mailing list