[PATCH] D132901: [LLD] Imply "longjmp" in `/guard:cf`

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: lld/COFF/DriverUtils.cpp:109-110
       config->guardCF |= GuardCFLevel::CF | GuardCFLevel::LongJmp;
     else if (arg.equals_insensitive("ehcont"))
       config->guardCF |= GuardCFLevel::CF | GuardCFLevel::EHCont;
     else
----------------
alvinhochun wrote:
> Since `ehcont` implies `cf`, perhaps in this case it should also imply `longjmp`?
No idea. But if we make `ehcont` imply `longjmp`, an option like `-guard:cf,nolongjmp,ehcont` won't disable `nolongjmp`. So it should align with MSVC too. Could you help to have a check? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132901/new/

https://reviews.llvm.org/D132901