[PATCH] D132452: [LSR] Precommit test for D132443

Tue Aug 30 03:08:42 PDT 2022

fhahn added a comment.

Thanks for the update! Given hat all those tests seem to be slight variations of each other, should they be moved in the same file, with a comment highlighting the differences, which are mostly the trip count and/or the complexity of the addrec

================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-complicate-add-rec.ll:36
+
+for.cond.cleanup:                                 ; preds = %for.body, %entry
+  ret void
----------------
nit: easier to right if the exit block is at the end.

================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-runtime-tripcount.ll:45
+  %wide.trip.count = zext i32 %0 to i64
+  %1 = add nsw i64 %wide.trip.count, -1
+  %uglygep = getelementptr i8, ptr %seq, i64 1
----------------
is this needed? Could we not have a simple variant of `/lsr-fold-iv-complicate-add-rec.ll` where the incoming value is something like `[ %N, %entry ]` instead of `[ 379, %entry ]`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132452/new/

https://reviews.llvm.org/D132452