[PATCH] D132912: [llvm-gsymutil] Fix tracking of currently open file

[Victor Michel via Phabricator via llvm-commits]

vikmik created this revision.
vikmik added reviewers: simon.giesecke, clayborg.
vikmik created this object with edit policy "Only User: vikmik (Victor Michel)".
vikmik added a project: LLVM.
Herald added a project: All.
vikmik requested review of this revision.
Herald added a subscriber: llvm-commits.

Prior to this change, `CurrentGSYMPath` was never updated. The GSYM file was reopened for every line from standard input, even if every line references the same file.

This change brings down runtime from ~4 seconds down to ~300ms on a test I'm doing (~25K frames from libxul)

(This is my first-ever LLVM change - sorry if I missed something in the process!)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132912

Files:
  llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp


Index: llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
===================================================================
--- llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
+++ llvm/tools/llvm-gsymutil/llvm-gsymutil.cpp
@@ -496,6 +496,7 @@
         CurrentGsym = GsymReader::openFile(GSYMPath);
         if (!*CurrentGsym)
           error(GSYMPath, CurrentGsym->takeError());
+        CurrentGSYMPath = GSYMPath;
       }
 
       uint64_t Addr;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132912.456548.patch
Type: text/x-patch
Size: 439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220830/290e167c/attachment.bin>