[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

Mon Aug 29 20:19:31 PDT 2022

MaskRay marked 5 inline comments as done.
MaskRay added inline comments.

================
Comment at: llvm/utils/lit/lit/llvm/config.py:570
+        clang_std_values = ('98', '11', '14', '17', '20', '2b')
+        def add_stdcxx(s):
+            t = s[8:]
----------------
aaron.ballman wrote:
> If we like this approach, we should probably add `add_stdc` as well (not as part of this patch, we can do all of C++ first, then come back and hit up C after we've finished).
Agree. This can be left as another patch.

================
Comment at: llvm/utils/lit/lit/llvm/config.py:579
+            l = h - clang_std_group % (h-l+1)
+            self.config.substitutions.append((s, '-std=c++' + clang_std_values[l]))
+
----------------
aaron.ballman wrote:
> MaskRay wrote:
> > aaron.ballman wrote:
> > > One thing we should consider is whether we want to run in *all* the specified language modes instead of just the newest mode. This will make running tests slower because we'll run significantly more of them, and it might get awkward if a lot of tests change behavior in the different language modes, so I don't suggest it as part of this patch.
> > This is difficult in lit. Will answer in my main comment.
> It's unfortunate that it's difficult in lit. I'm fine punting on that work for now, but I think we should try to invest in it (or are you saying "difficult" as in "not worth the effort"?)
I have asked for help on https://discourse.llvm.org/t/lit-run-a-run-line-multiple-times-with-different-replacements/64932

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131464/new/

https://reviews.llvm.org/D131464