[PATCH] D132390: [MCContext] Reverse order of DebugPrefixMap sort for generated assembly debug info

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 18:45:46 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/include/llvm/MC/MCContext.h:193
   /// Prefix replacement map for source file information.
-  std::map<const std::string, const std::string> DebugPrefixMap;
+  std::map<std::string, const std::string, std::greater<std::string>>
+      DebugPrefixMap;
----------------
dankm wrote:
> What happened to the const qualifier here?
const key is very uncommon and constness usually doesn't matter (value_type adds const to the key type anyway).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132390/new/

https://reviews.llvm.org/D132390



More information about the llvm-commits mailing list