[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:599
+        if (Changed)
+          FreshBBs.insert(&BB);
+        else if (FuncIterated)
----------------
LuoYuanke wrote:
> The sinked BB also changed and may have several sinked BBs. Do we record the all sinked BBs in FreshBBs?
Yes, all updated BB will be put into FreshBBs. Most of them are inserted in updated replaceAllUsesWith.
For BB which no update, we just optimize them one time.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:603
+
+      if (ModifiedDTOnIteration == ModifyDT::ModifyBBDT)
+        DT.reset();
----------------
LuoYuanke wrote:
> indent.
good catch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352