[PATCH] D128998: [libunwind] Handle G in personality string

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 17:25:19 PDT 2022


MaskRay added a comment.

> Can you describe the clang command line? It's unclear how MTE is used.

Unaddressed.

> Should I move the extern int __unw_clean_step(unw_cursor_t *); declaration out of libunwind_ext.h if I don't want it to be an API?

Good idea. `__unw_clean_step` does not seem suitable to be an API when the nongnu libunwind discussion has not happened.

> The clean part in the name and the clean parameter feels unclear to me.

And this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998



More information about the llvm-commits mailing list