[PATCH] D132094: [profile] Create only prof header when no counters

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 15:20:23 PDT 2022


ellis added inline comments.


================
Comment at: compiler-rt/test/profile/Posix/instrprof-empty-profile.c:20
+// RAW-PROFILE-HEADER-ONLY: Instrumentation level: Front-end
+// RAW-PROFILE-HEADER-ONLY-NEXT: Total functions: 0
+// RAW-PROFILE-HEADER-ONLY-NEXT: Maximum function count: 0
----------------
gulfem wrote:
> ellis wrote:
> > I think this might be the only important line to check. Do we need to check the other lines too?
> Appreciate for all the feedback @ellis! 
> I prefer to check all the other lines to make sure that we have only 0s.
> For this test it might not be important, but for the shared library test (`instrprof-shared-empty-profile.test`), I would like to verify the accurate values. 
Sounds good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132094/new/

https://reviews.llvm.org/D132094



More information about the llvm-commits mailing list