[PATCH] D132876: [AMDGPU][MC][GFX11][NFC] Update asm tests for VOP3P instructions

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 11:47:04 PDT 2022


Joe_Nash accepted this revision.
Joe_Nash added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s:306
+
+v_fma_mix_f32 v5, -|-1|, m0, -|-1| op_sel:[1,0,0] op_sel_hi:[0,1,0]
+// GFX11: [0x05,0x0d,0x20,0xcc,0xc1,0xfa,0x04,0xb3]
----------------
Interesting, I didn't consider you could modify the inline constants. I think only useful case would minus on inline 1/(2*PI), the other constants also have a negative version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132876/new/

https://reviews.llvm.org/D132876



More information about the llvm-commits mailing list