[PATCH] D132826: [DirectX backend] change MinVectorRegisterBitWidth to 32.

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 29 11:42:22 PDT 2022


python3kgae updated this revision to Diff 456428.
python3kgae added a comment.

Remove check-not which is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132826/new/

https://reviews.llvm.org/D132826

Files:
  llvm/lib/Target/DirectX/DirectXTargetTransformInfo.h
  llvm/test/CodeGen/DirectX/min_vec_size.ll


Index: llvm/test/CodeGen/DirectX/min_vec_size.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/DirectX/min_vec_size.ll
@@ -0,0 +1,21 @@
+; RUN: opt -S -vector-combine < %s | FileCheck %s
+
+target datalayout = "e-m:e-p:32:32-i1:32-i8:8-i16:16-i32:32-i64:64-f16:16-f32:32-f64:64-n8:16:32:64"
+target triple = "dxil-unknown-shadermodel6.7-library"
+
+; Make sure vec combine min vec size is 1 instead of 4 for float.
+; CHECK:@foo()
+; CHECK-NEXT:%[[LD:[0-9]+]] = load <1 x float>, ptr @a, align 8
+; CHECK-NEXT:%insert = shufflevector <1 x float> %[[LD]], <1 x float> poison, <2 x i32> <i32 0, i32 undef>
+; CHECK-NEXT:%shuffle = shufflevector <2 x float> %insert, <2 x float> poison, <2 x i32> zeroinitializer
+; CHECK-NEXT:ret <2 x float> %shuffle
+
+ at a = external local_unnamed_addr constant float
+
+; Function Attrs: mustprogress nofree norecurse nosync nounwind readnone willreturn
+define noundef <2 x float> @foo() local_unnamed_addr {
+  %1 = load float, ptr @a, align 8
+  %insert = insertelement <2 x float> poison, float %1, i64 0
+  %shuffle = shufflevector <2 x float> %insert, <2 x float> poison, <2 x i32> zeroinitializer
+  ret <2 x float> %shuffle
+}
Index: llvm/lib/Target/DirectX/DirectXTargetTransformInfo.h
===================================================================
--- llvm/lib/Target/DirectX/DirectXTargetTransformInfo.h
+++ llvm/lib/Target/DirectX/DirectXTargetTransformInfo.h
@@ -33,6 +33,7 @@
   explicit DirectXTTIImpl(const DirectXTargetMachine *TM, const Function &F)
       : BaseT(TM, F.getParent()->getDataLayout()), ST(TM->getSubtargetImpl(F)),
         TLI(ST->getTargetLowering()) {}
+  unsigned getMinVectorRegisterBitWidth() const { return 32; }
 };
 } // namespace llvm
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132826.456428.patch
Type: text/x-patch
Size: 1777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220829/f3ed9b53/attachment.bin>


More information about the llvm-commits mailing list